Skip to content

Sync with upstream @ 4d01fc20#191

Closed
javascript-translate-bot wants to merge 117 commits into
masterfrom
sync-4d01fc20
Closed

Sync with upstream @ 4d01fc20#191
javascript-translate-bot wants to merge 117 commits into
masterfrom
sync-4d01fc20

Conversation

@javascript-translate-bot

Copy link
Copy Markdown
Contributor

This PR was automatically generated to merge changes from en.javascript.info at 4d01fc2

Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.

Alternatively, you can close this PR and merge conflicting changes manually.

The following files have conflicts and may need updates of the translations:

To merge changes manually (instead of merging this PR):

  1. Add remote upstream that links to the English version (only needs to be done once)
    • git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
  2. Commit all current work locally and git checkout master
  3. Pull the recent changes from the English version:
    • git pull upstream master
  4. Deal with the conflicts. If a conflict touches a few lines, then just fix it. Otherwise, following commands can help:
    • Checkout your (translated) version of a file/folder at the given path (removes all upstream changes):
      • git checkout --ours <path>
    • See the diff, what changed in the upstream file since branches diverged:
      • git diff --word-diff master...upstream/master <path> (please note: three dots in the command)
    • Then you can examine the changes in upstream and add them manually
  5. When conflicts resolved, commit them and git push origin master

This PR will be closed and replaced with a new one in a few days.

joaquinelio and others added 30 commits March 28, 2021 00:08
"inserts into" instead of "appends to"
Removed unnecessary escape characters from regex in "getCookie function in cookie.js" - 
. ( ) [ / +
The above characters don't need escaping.
Unnecessary escape characters in cookie.js
…rties-methods

It looks like code was changed some time ago, but comments didn't change accordingly.
minor edit to 1-js/05-data-types/02-number/
slightly improve clarity of Promise.all()
@CLAassistant

CLAassistant commented Aug 23, 2021

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 6 committers have signed the CLA.

✅ joaquinelio
✅ odsantos
✅ iliakan
❌ siimpragi
❌ msmilkshake
❌ shvchk
You have signed the CLA already but the status is still pending? Let us recheck it.

@tarasyyyk

Copy link
Copy Markdown
Collaborator

@iliakan, привет. Я уже добавлял эти изменения в ветку master.
Но они до сих пор появляются в новых PR. Это уже 3 раз. Раньше такого не было. Что случилось? Может я неправильно вношу изменения?
Я переключаюсь на ветку sync-4d01fc20 исправляю конфликты, пушу в репозиторий, и мерджу с мастером.

@iliakan

iliakan commented Aug 23, 2021

Copy link
Copy Markdown
Member

То есть, ты заходил на гитхаб и мержил этот PR уже?

@tarasyyyk

Copy link
Copy Markdown
Collaborator

@iliakan нет, не именно этот, а предыдущий. Вот этот: #185 — в нем все эти изменения уже были

@iliakan

iliakan commented Aug 23, 2021

Copy link
Copy Markdown
Member

Видимо, что-то не то со структурой веток произошло.

Изменения из этого PR уже не нужны, верно понимаю? Они все интегрированы?

@tarasyyyk

Copy link
Copy Markdown
Collaborator

@iliakan да, все изменения из этого PR уже есть.

@iliakan iliakan closed this Aug 23, 2021
@iliakan

iliakan commented Aug 23, 2021

Copy link
Copy Markdown
Member

Если еще появится - пиши =)

@iliakan

iliakan commented Aug 23, 2021

Copy link
Copy Markdown
Member

Замержил по идее.

/opt/javascript-nodejs/repo/uk.javascript.info master
❯ git merge -s ours upstream/master
Merge made by the 'ours' strategy.

@tarasyyyk

Copy link
Copy Markdown
Collaborator

@iliakan я еще удаляю ветки sync-... после мержа. Это не влияет на следующий PR?

@iliakan

iliakan commented Aug 24, 2021

Copy link
Copy Markdown
Member

Нет, не влияет.

@tarasyyyk tarasyyyk deleted the sync-4d01fc20 branch August 24, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.